Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating with URL parameters/supporting browser "back" button? #30

Open
rik-iso opened this issue Jan 5, 2025 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@rik-iso
Copy link

rik-iso commented Jan 5, 2025

Curious if you've thought about (or would ever support) a way to optionally integrate react-call with URL state so that native navigation (i.e. hitting back) would work to close modals opened using it? Effectively using the URL as the state manager instead of whatever you're doing today.

It probably gets tricky especially given any arbitrary parameters can be sent to react-call, but the use case of not breaking the back button would be good.

@rik-iso rik-iso changed the title Integrating with URL parameters? Integrating with URL parameters/supporting browser "back" button? Jan 5, 2025
@desko27 desko27 added the enhancement New feature or request label Jan 6, 2025
@desko27
Copy link
Owner

desko27 commented Jan 21, 2025

While this can already be achieved by subscribing to navigation events and triggering call.end() from there, that's some manual work and I understand this is typical enough to provide a more out-of-the-box opt-in solution.

Thanks for your suggestion @rik-iso, I'll keep it on the radar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants