Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicEncryptionkey & publicKeyId still required for encryption ? #36

Closed
ehanoc opened this issue Feb 9, 2025 · 0 comments
Closed

publicEncryptionkey & publicKeyId still required for encryption ? #36

ehanoc opened this issue Feb 9, 2025 · 0 comments
Assignees
Labels
question Further information is requested

Comments

@ehanoc
Copy link

ehanoc commented Feb 9, 2025

Given that we are using ECIES now and moved away from RSA.

Does

 /**
  * public key in PEM encoding format
  */
 string publicEncryptionKey = 1;
 
/**
  * A number used to later identify the publicEncryptionKey. 
  * When a message is sent to the creator of this contact, and it is encrypted
  * with the publicEncryptionKey, this identifier is also sent, so the recipient 
  * knows which key to use to decrypt it. If the recipient creates multiple 
  * keys for multiple pairings, then they should remember the publicKeyId that
  * they chose for each one, so they won't have to try all the keys during decryption. 
  */
 int32 publicKeyId = 2;

Still make sense keeping?

AFAIK, encryption will be through a symmetric secret generated by an agreement (ECDH) after public key exchange.

We should only need the publicKeys of the other parties to perform both encryption and signature verification?

@ehanoc ehanoc added the question Further information is requested label Feb 9, 2025
@ehanoc ehanoc self-assigned this Feb 9, 2025
@larkiny larkiny closed this as completed Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants