Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The definition of maxShareSize/minShareSize #29

Open
zanctor opened this issue Jan 22, 2024 · 2 comments
Open

The definition of maxShareSize/minShareSize #29

zanctor opened this issue Jan 22, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@zanctor
Copy link
Collaborator

zanctor commented Jan 22, 2024

Considering, that it is possible for a helper to store several versions of a secret at the same time, what exactly maxShareSize/minShareSize should limit? Should it be the size of every version for the given secret or the size of all stored versions of this secret combined?

@zanctor
Copy link
Collaborator Author

zanctor commented Jan 25, 2024

For now we decided to apply this limit to the size of the shared secret version.

Also, it makes sense to add more parameters like a number of secret versions to store or a number of secrets per peer.

@Loedn Loedn added the documentation Improvements or additions to documentation label Aug 28, 2024
@Loedn
Copy link
Collaborator

Loedn commented Aug 28, 2024

todo: add documentation clarifying (it includes all shares)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants