Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publicSignatureKey to the ContactMessage protobuf #26

Open
zanctor opened this issue Jan 19, 2024 · 1 comment
Open

Add publicSignatureKey to the ContactMessage protobuf #26

zanctor opened this issue Jan 19, 2024 · 1 comment
Assignees

Comments

@zanctor
Copy link
Collaborator

zanctor commented Jan 19, 2024

A public signature key is required for the message signature verification. However, during the pairing sequence, an initiator does not know a responder's signature key to be able to verify a pairing response right away. It needs to decrypt the message and take this key from it. This might be an inconvenience in some programming languages and/or PGP implementations, where the message handling is done using streams (e.g. Java) or another similar concept since there might be a need to decrypt the message twice (to get the signature key first, and then decrypt-and-verify again with that key).

Thus I suggest adding a responder's signature key to the ContactMessage protobuf, so any implementation will be able to decrypt and verify the pair response message at once. Also, the publicSignatureKey field can be removed from the PairResponseMessage protobuf in this case.

@jorabin
Copy link
Contributor

jorabin commented Jan 19, 2024

Agree that the ContactMessage should contain public signature key of responder for the reason @zanctor gives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants