Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature scaffolding - added centralized handling of resources removed from the server and state management #23

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Feature scaffolding - added centralized handling of resources removed from the server and state management #23

merged 6 commits into from
Jul 25, 2024

Conversation

ShocOne
Copy link
Contributor

@ShocOne ShocOne commented Jul 25, 2024

Change

Feel free to remove this sample text

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

ShocOne added 6 commits July 25, 2024 13:16
@ShocOne
refactor: Safely handle nil values in assignment filter resource cons…
8e77840 
…truction
@ShocOne
refactor: Safely handle nil values in assignment filter resource cons…
fed5a1e 
…truction
@ShocOne
refactor: Safely handle nil values in assignment filter resource cons…
6d0134e 
…truction
@ShocOne
refactor:handling of resources removed from the server
8b650af
@ShocOne
refactor: Improve assignment filter resource construction
b390995 
Refactor the construction of the assignment filter resource in `state.go` and `object.go` for improved readability and visibility. The changes include:
- Safely dereferencing string pointers to avoid nil pointer errors
- Safely converting enums to their string representation
- Handling nil values for various fields in the assignment filter resource

These refactorings enhance the code readability and provide better visibility into the constructed assignment filter resource.
@ShocOne
refactor: Improve assignment filter resource construction
d62d957 
Refactor the construction of the assignment filter resource in `state.go` and `object.go` for improved readability and visibility. Safely dereference string pointers, convert enums to string representation, and handle nil values. Enhance code readability and provide better visibility into the constructed assignment filter resource.
@ShocOne ShocOne merged commit 28944a9 into main Jul 25, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ShocOne