Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve sorting problem between API response and list of resource definitions #600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Resolve sorting problem between API response and list of resource definitions #600

wants to merge 1 commit into from

Conversation

kenchan0130
Copy link
Contributor

FIX #254

@kenchan0130 kenchan0130 requested a review from ShocOne as a code owner February 25, 2025 03:59
@kenchan0130 kenchan0130 changed the title Resolve sorting problem between API response and list of resource definitions fix: Resolve sorting problem between API response and list of resource definitions Feb 25, 2025
ShocOne
ShocOne reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@ShocOne ShocOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @kenchan0130 , the PR is missing changes to the constructor logic and stating logic. just changing the schema alone from list -> set won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShocOne ShocOne ShocOne left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration profile computer group IDs ordering
2 participants
@kenchan0130 @ShocOne