Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not able to parse pyproject.toml if contain property" package-mode=false" #9209

Closed
1 task done
siongwai opened this issue Mar 5, 2024 · 4 comments
Closed
1 task done
Labels
L: python:poetry Python packages via poetry T: bug 🐞 Something isn't working

Comments

@siongwai
Copy link

siongwai commented Mar 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

pip

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

I am having a pyproject.toml in root level

content will be:

[tool.poetry]
name = "abc"
version = "0.1.0"
description = "Example"
authors = ["Your Name <[email protected]>"]
# packages = []
package-mode = false

[tool.poetry.dependencies]
python = "^3.10"
robotframework = "7.0"
robotframework-browser = "18.1.0"
robotframework-jsonlibrary = "0.5"
robotframework-pabot = "2.16.0"
robotframework-pythonlibcore = "4.3.0"
robotframework-requests = "0.9.5"
timecode = "1.3.0"

[tool.poetry.group.dev.dependencies]
robotframework-robocop = "5.0.3"
robotframework-tidy = "4.10.0"
ruff = "0.3.0"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

dependabot.yml content

# Basic dependabot.yml file with
# minimum configuration package managers

version: 2
updates:
  # Configuration for pip
  - package-ecosystem: "pip"
    directory: "/"
    schedule:
      interval: "daily"

Updated dependency

No response

What you expected to see, versus what you actually saw

Expected to see:
Able to parse pyproject.toml and create PR for monitored packages.

What I see:
dependabot return error, part of the error quote below

updater | 2024/03/05 06:40:50 INFO <job_796061961> [Transport] Sending envelope with items [event] ebb1076325524c3db7edd5847ce2700b to Sentry
proxy | 2024/03/05 06:40:50 [066] POST https://sentry.io:443/api/1451818/envelope/
proxy | 2024/03/05 06:40:50 [066] 200 https://sentry.io:443/api/1451818/envelope/
updater | 2024/03/05 06:40:51 ERROR <job_796061961> Error processing robotframework-requests (Dependabot::SharedHelpers::HelperSubprocessFailed)
updater | 2024/03/05 06:40:51 ERROR <job_796061961> The Poetry configuration is invalid:
updater | - Additional properties are not allowed ('package-mode' was unexpected)
updater | 2024/03/05 06:40:51 ERROR <job_796061961> /home/dependabot/common/lib/dependabot/shared_helpers.rb:429:in run_shell_command' updater | 2024/03/05 06:40:51 ERROR <job_796061961> /home/dependabot/dependabot-updater/vendor/ruby/3.1.0/gems/sorbet-runtime-0.5.11193/lib/types/private/methods/call_validation.rb:169:in bind_call'

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@siongwai siongwai added the T: bug 🐞 Something isn't working label Mar 5, 2024
@mikicz
Copy link

mikicz commented Mar 5, 2024

I believe an upgrade to poetry 1.8.x should fix this

@siongwai
Copy link
Author

siongwai commented Mar 7, 2024

Waiting for #9189 to be merged

@OldSneerJaw
Copy link

OldSneerJaw commented Mar 15, 2024

Dependabot has now automatically closed the original pull request and opened a new one: #9291. It is blocked by dependabot/smoke-tests#191.

@abdulapopoola
Copy link
Member

This should be fixed with #9291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: python:poetry Python packages via poetry T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants