Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: "internal:" specifiers should support relative imports #17769

Closed
bartlomieju opened this issue Feb 13, 2023 · 3 comments
Closed

core: "internal:" specifiers should support relative imports #17769

bartlomieju opened this issue Feb 13, 2023 · 3 comments
Assignees
@bartlomieju
Labels
deno_core Changes in "deno_core" crate are needed refactor

Comments

@bartlomieju
Copy link
Member

No description provided.

@bartlomieju bartlomieju self-assigned this Feb 13, 2023
@bartlomieju bartlomieju added deno_core Changes in "deno_core" crate are needed refactor labels Feb 15, 2023
@bartlomieju
Copy link
Member Author

To do this we will probably need to change internal specifiers to use internal:/<crate_name>/<file_name> - otherwise we'll get "cannot-be-a-base-base" error for referrer.

@bartlomieju
Copy link
Member Author

bartlomieju commented May 28, 2023 •
edited
Loading

@nayeemrmn it appears to me that with your changes in #19040 this should be much more approachable. Do you see any potential problems here?

I'm still interested in this because that would make a bunch of strings shorter in the snapshot lowering its size :)

@bartlomieju
Copy link
Member Author

I don't actually want it anymore. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlomieju bartlomieju

Labels
deno_core Changes in "deno_core" crate are needed refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartlomieju