Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel interface for battery controls #84

Open
awehrfritz opened this issue Feb 1, 2020 · 9 comments
Open

Kernel interface for battery controls #84

awehrfritz opened this issue Feb 1, 2020 · 9 comments

Comments

@awehrfritz
Copy link
Contributor

Are there any plans to add support for interacting with the battery controls in the Dell kernel driver (analog to the implementation in libsmbios, just in the kernel)?

As I have outlined already in an issue for the TLP utility (linrunner/TLP#321 (comment) and linrunner/TLP#321 (comment)), Google has introduced a set of new sysfs attributes and infrastructure that makes it fairly easy to implement extended controls for power supplies, and in particular batteries (for details see Documentation/ABI/testing/sysfs-class-power and drivers/power/supply/power_supply_sysfs.c).

This appears to be primarily aimed at their new Embedded Controller (Wilco EC) on the chromebook platform (drivers/power/supply/wilco-charger.c and Documentation/ABI/testing/sysfs-class-power-wilco), but in particular the charge modes and battery charging threshold settings in custom mode of the Wilco EC map directly to the ones found in Dell laptops.

Support for Huawei and Asus laptops to use this new sysfs interface has also been implemented, and the Lenovo driver may also be ported over soon.

Last, if there is a better place to report feature request for the Dell laptop driver in the Linux kernel, I would appreciate if someone could direct to the right place/forum for that.

@superm1
Copy link
Contributor

superm1 commented Feb 1, 2020

I think it makes fine sense to do. It's probably best to raise on the platform drivers x86 mailing list to see if anyone is working on it or intending on working on it yet. Pali Rohar has done a lot of the work on that driver already.

@awehrfritz
Copy link
Contributor Author

Just to keep track of this also here, there are patches now which implement this: https://lkml.org/lkml/2020/7/29/87

@fggarcia
Copy link

@superm1 continue my comment from my expirience to avoid comment on closed issue. I'm trying config threshold for my XPS 9300.

@linrunner
Copy link

Any news on this? TLP 1.4 will have the infrastructure to support charge thresholds for Non-ThinkPads.

@superm1
Copy link
Contributor

superm1 commented Apr 21, 2021

@linrunner @GoPerry was working on a kernel interface for it. @GoPerry can you provide an update?

@GoPerry
Copy link

GoPerry commented Apr 29, 2021

@linrunner @GoPerry was working on a kernel interface for it. @GoPerry can you provide an update?
@linrunner @superm1
I have another kernel patch that will need to be submitted soon.
It will have the feature to support battery thresholds setting.

@linrunner
Copy link

@superm1 @GoPerry : is the topic still being worked on?

@superm1
Copy link
Contributor

superm1 commented Dec 7, 2021

Neither of us are at Dell anymore. @dell-client-linux would need to comment.

@gagath
Copy link

gagath commented May 8, 2022

Hi, still interested in this issue. Can Dell provide us updates about this kernel support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants