Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

byte[] fromBase64(String hex) param incorrectly named #84

Open
doridori opened this issue Jan 25, 2017 · 1 comment
Open

byte[] fromBase64(String hex) param incorrectly named #84

doridori opened this issue Jan 25, 2017 · 1 comment
Labels
enhancement

Comments

@doridori
Copy link

https://github.com/defuse/password-hashing/blob/master/PasswordStorage.java#L191

shows the method interface byte[] fromBase64(String hex) which is strange - why is the input param called hex (as its not hexadecimal)?
@defuse
Copy link
Owner

defuse commented Jan 25, 2017

Yeah, that's an error. It used to be hex encoded and I forgot to change the parameter name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doridori @defuse