-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] CMake incorrectly forces C++14 #4569
Labels
Comments
Thanks for report. I didn't realize that C++ 17 has been used. |
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this issue
Jan 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 24, 2025
Fix #4569. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Build Configuration** - Enhanced flexibility in C++ standard settings based on project dependencies - Added conditional checks for setting C++ standard version - **Code Improvements** - Updated type checking mechanisms in compute methods - Refined method signatures for handling different data types in DeepPotPT and DeepSpinPT classes - **Technical Refinements** - Improved conditional compilation and configuration handling - Introduced more flexible type-specific method overloads <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Thanks a lot for the quick fix! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug summary
I was unable to build DeePMD with PyTorch from source because the code requires C++17 but CMake forces C++14:
deepmd-kit/source/CMakeLists.txt
Lines 24 to 27 in e5eac4a
DeePMD-kit Version
3.0.1
Backend and its version
PyTorch
How did you download the software?
Built from source
Input Files, Running Commands, Error Log, etc.
Building DeePMD with PyTorch like this:
Leads to errors like these:
Steps to Reproduce
Further Information, Files, and Links
No response
The text was updated successfully, but these errors were encountered: