Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use confidential computing provisioned secrets for disk decryption #18

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

wojiaohanliyang
Copy link

@wojiaohanliyang wojiaohanliyang commented Nov 21, 2024

Extend the cryptodisk module to retrieve confidential computing secrets from the UEFI GUID table, with the assistance of a new module named efisecret.

@deepin-ci-robot
Copy link
Contributor

Hi @wojiaohanliyang. Thanks for your PR. 😃

Copy link

TAG Bot

TAG: 2.12-1deepin14
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hudeng-go for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

Hi @wojiaohanliyang. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Zeno-sole
Copy link
Contributor

/topic hygon-20241128

@deepin-ci-robot
Copy link
Contributor

Add topic: hygon-20241128 successed.

@Zeno-sole
Copy link
Contributor

/integr-topic hygon-20241128

+grub_efi_secret_put (const char *arg __attribute__((unused)), int have_it,
+ grub_uint8_t **ptr)
+{
+ struct secret_entry *e = (struct secret_entry *)(*ptr - (long)&((struct secret_entry *)0)->data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码是不是可以优化一下,编辑器报警告了

@Zeno-sole Zeno-sole merged commit 492ed59 into deepin-community:master Nov 29, 2024
2 checks passed
wojiaohanliyang pushed a commit to wojiaohanliyang/github_deepin-community_edk2 that referenced this pull request Dec 24, 2024
The build depends on /usr/lib/grub/x86_64-efi/efisecret.module. So, when
build the edk2, you should ensure the grub2 installed on the build
system have already contains the code in PR:

  deepin-community/grub2#18.

Signed-off-by: hanliyang <[email protected]>
Zeno-sole pushed a commit to deepin-community/edk2 that referenced this pull request Jan 10, 2025
The build depends on /usr/lib/grub/x86_64-efi/efisecret.module. So, when
build the edk2, you should ensure the grub2 installed on the build
system have already contains the code in PR:

  deepin-community/grub2#18.

Signed-off-by: hanliyang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants