Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call transcribe_url_callback when callback is provided #181

Closed
davidvonthenen opened this issue Nov 14, 2023 · 1 comment
Closed

Call transcribe_url_callback when callback is provided #181

davidvonthenen opened this issue Nov 14, 2023 · 1 comment

Comments

@davidvonthenen
Copy link
Contributor

Proposed changes

Reported by @jjmaldonis:
If a callback is passed to prerecorded.transcribe_url, can we automatically call prerecorded.transcribe_url_callback rather than throw an error? I think we know what the caller is intending to do, so let's do it. Same for prerecorded.transcribe_file.

Context

NA

Possible Implementation

NA

Other information

NA

@davidvonthenen
Copy link
Contributor Author

This PR should address the problem. If it doesn't, we can reopen.
#182

Cc: @jjmaldonis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants