You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reported by @jjmaldonis:
I think the is_json method in helpers.py should be removed and the calling-code should be updated to use try/except. When is_json returns True, the json data gets deserialized twice: once by is_json and a 2nd time by the calling code. JSON deserialization is quite slow, so only running it once should make a noticeable difference (although I guess the HTTP requests will probably always by 100x slower, so ... maybe ignore ... but it's likely to be a criticism of anyone reading the code).
Steps to reproduce
NA
Expected behavior
NA
Please tell us about your environment
NA
Other information
NA
The text was updated successfully, but these errors were encountered:
What is the current behavior?
Reported by @jjmaldonis:
I think the is_json method in helpers.py should be removed and the calling-code should be updated to use try/except. When is_json returns True, the json data gets deserialized twice: once by is_json and a 2nd time by the calling code. JSON deserialization is quite slow, so only running it once should make a noticeable difference (although I guess the HTTP requests will probably always by 100x slower, so ... maybe ignore ... but it's likely to be a criticism of anyone reading the code).
Steps to reproduce
NA
Expected behavior
NA
Please tell us about your environment
NA
Other information
NA
The text was updated successfully, but these errors were encountered: