Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need small fix #10

Closed
username1565 opened this issue Nov 24, 2019 · 3 comments
Closed

Need small fix #10

username1565 opened this issue Nov 24, 2019 · 3 comments

Comments

@username1565
Copy link

username1565 commented Nov 24, 2019

Un-leasing, this is outgoing transfer, not incoming:
изображение

Just reverse this bracket quote.

@deemru
Copy link
Owner

deemru commented Nov 25, 2019

This is a misunderstanding, the actual point is:

  • < = incoming transaction
  • > = outgoing transaction

If someone did unlease from a node, it is someone's action, not the node action, so it cannot be >.

Another way of thinking is to imagine whos signature on a transaction. If it is not you then it is always incoming '<' transaction.

@deemru deemru closed this as completed Nov 25, 2019
@username1565
Copy link
Author

If someone cansel his leasing, then generating balance on the node is decreasing, so this transfer is a outgoing transaction from the generating balance of the node-address, and node cann't do mining, using this unleasing waves.
This is the main point, why I think,
that will be better to mark un-leasing transactions as outgoing transactions.
Yes, this is not depending from node-owner, and he don't sign this transactions,
but maybe this un-leasing is a result of strategy of his business, and in this case, the node owner can take some decisions to protect his business, if he sees that the balance on the node is reduced due to outgoing transactions to balances of his creditors, who give their WAVES to him in leasing.

@deemru
Copy link
Owner

deemru commented Nov 28, 2019

but maybe this un-leasing is a result of strategy of his business

Then he should add this case to his code appropriate.

I do not see why it should change the global and very straightforward logic of w8io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants