Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect unlit/lit material props when loading GLTFs and set their material accordingly #371

Open
pravusjif opened this issue Jan 20, 2025 · 0 comments
Labels
enhancement New feature or request unity

Comments

@pravusjif
Copy link
Member

pravusjif commented Jan 20, 2025

Today every GLTF is loaded with a PBR material.

We should be able to detect either the usage or the missing usage of PBR properties in the original GLTF Material and configure the Decentraland material+shader accordingly.

Key point: ALPHA MASK is not supported on PBR materials anymore, if creators want to keep using ALPHA MASK on GLTFs, they have to configure the GLTF Material to represent an Unlit material.

Raw GLTF Material generation: https://github.com/decentraland/unity-shared-dependencies/blob/b1a299af370b59d141cba3ad49149ea209bc0be1/Runtime/GLTFastWrappers/DecentralandMaterialGenerator.cs#L35

@pravusjif pravusjif added enhancement New feature or request unity labels Jan 20, 2025
@github-project-automation github-project-automation bot moved this to Todo in SDK Jan 20, 2025
@pravusjif pravusjif moved this from Todo to In Progress in SDK Jan 21, 2025
@pravusjif pravusjif moved this from Todo to In Progress in Explorer Alpha Jan 21, 2025
@pravusjif pravusjif assigned pravusjif and unassigned pravusjif Jan 21, 2025
@pravusjif pravusjif moved this from In Progress to Todo in SDK Jan 21, 2025
@pravusjif pravusjif moved this from In Progress to Todo in Explorer Alpha Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unity
Projects
Status: Todo
Status: Todo
Development

No branches or pull requests

1 participant