Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the "debate finished" view #90

Closed
Mateusz-Dobrzynski opened this issue Jun 27, 2024 · 2 comments · Fixed by #101
Closed

Enhance the "debate finished" view #90

Mateusz-Dobrzynski opened this issue Jun 27, 2024 · 2 comments · Fixed by #101
Assignees
Labels
enhancement New feature or request parity Implement a lost feature or something competitors do

Comments

@Mateusz-Dobrzynski
Copy link
Member

During PND, I noticed one marshal misuse the clock, i.e. press the "back" button after every speech, because the clock had not been reset after a previous debate. This got me thinking that the "debate finished" view could be more direct in messaging that the debate is indeed over.

Ideas

  • Dim and/or blur the screen and add a message displayed in the center, similarly to how it was done in d0b3590. I think "Debate Finished 🎉" was a good one;
  • Add a "reset" button, possibly represented with a repeat icon, setting the debate state back to stage one.
@Mateusz-Dobrzynski Mateusz-Dobrzynski added the enhancement New feature or request label Jun 27, 2024
@jakubmanczak
Copy link
Member

Agree about the 🎉 – will surely bring it back.

@jakubmanczak jakubmanczak self-assigned this Jul 3, 2024
@jakubmanczak
Copy link
Member

Going back to the report at hand though, wouldn't that cause the clock to display wrongful information about the current debate? Like, wrong motion, wrong team names? How does one miss all that?

@jakubmanczak jakubmanczak linked a pull request Jul 24, 2024 that will close this issue
@jakubmanczak jakubmanczak added the parity Implement a lost feature or something competitors do label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parity Implement a lost feature or something competitors do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants