Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fan never turns off after motion stops #6

Open
trusnock opened this issue Jul 20, 2019 · 0 comments
Open

Fan never turns off after motion stops #6

trusnock opened this issue Jul 20, 2019 · 0 comments

Comments

@trusnock
Copy link

hasBeenRecentMotion() refers to underfined "minutes" instead of "minutesNoMotion" so it always defaults to isActive = true. Easy fix but I don't have permissions to create a branch:

- if (motionSensor && minutes) {
- def deltaMinutes = minutes as Long
+ if (motionSensor && minutesNoMotion) {
+ def deltaMinutes = minutesNoMotion as Long

Thanks for all the work, this SmartApp is working great for me so far!

-Tom
atehrani added a commit to atehrani/KOF-CeilingFan that referenced this issue May 19, 2020
@atehrani
Fix for dcoffing#6
023ca77
CovertJaguar added a commit to CovertJaguar/KOF-CeilingFan that referenced this issue Aug 13, 2020
@CovertJaguar
Merge pull request #2 from atehrani/patch-1
76a44fa 
Fix for dcoffing#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trusnock