Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid JSON payload crashes worker thread #4

Closed
clorenz opened this issue Jun 29, 2018 · 1 comment
Closed

Invalid JSON payload crashes worker thread #4

clorenz opened this issue Jun 29, 2018 · 1 comment
Assignees
@clorenz

Comments

@clorenz
Copy link
Member

clorenz commented Jun 29, 2018

Passing an invalid JSON string as payload crashes the worker thread by terminating its endless loop.

Possible cure: In RabbitClient.receive, if the deserializer catches an exception, use response.getEnvelope().getDeliveryTag() to shift the message in to the failed queue and ACK it.
@clorenz clorenz self-assigned this Jul 5, 2018
@clorenz
Copy link
Member Author

clorenz commented Jul 5, 2018

Fixed in 2.2.0

@clorenz clorenz closed this as completed Jul 5, 2018
clorenz added a commit that referenced this issue Jul 5, 2018
@clorenz
[Issue #4]: Invalid JSON payload is now rejected gracefully
6706f3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clorenz clorenz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clorenz