Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Engine: Remove appName/creation DefaultProcessReport #189

Closed
3 tasks
bitzl opened this issue Jun 19, 2020 · 0 comments
Closed
3 tasks

Simplify Engine: Remove appName/creation DefaultProcessReport #189

bitzl opened this issue Jun 19, 2020 · 0 comments

Comments

@bitzl
Copy link
Member

bitzl commented Jun 19, 2020 •
edited
Loading

The Engine has a constructor parameterappName that is only used to create a new instance of DefaultProcessReport if no ProcessReport is given. Since the configuration is now supposed to be handled by ConfigurationProperties and Spring configurations, any creation of a ProcessReport should happen outside of Engine.

Todos:

  • Remove parameter appName
  • Remove construction of ProcessReport from Engine and make sure construction happens in FlusswerkConfiguration
  • Remove extra constructors
@bitzl bitzl closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bitzl