Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release co-ordination: v2.0.2 #28

Open
xurizaemon opened this issue Aug 1, 2021 · 4 comments
Open

Release co-ordination: v2.0.2 #28

xurizaemon opened this issue Aug 1, 2021 · 4 comments
Assignees

Comments

@xurizaemon
Copy link
Collaborator

xurizaemon commented Aug 1, 2021

Hey @davidar - thanks for adding me as a collaborator :)

I've created a draft release of v2.0.2 per docs at managing releases in a repository. I didn't see the "create a discussion" checkbox (perms, probably) so I've manually opened this issue. Assigning you as FYI.

Is v2.0.2 the correct next release? It's a bugfix / patch IMO, but we're changing SDK from 9 to 12. Maybe 2.1.0 is more appropriate, but there are no new features.

I have access sufficient to publish but want to check in with you first :)

@xurizaemon
Copy link
Collaborator Author

I'm going to publish this release, hope that's OK!

@xurizaemon
Copy link
Collaborator Author

xurizaemon commented Sep 19, 2021

Publishing the release doesn't seem to have kicked off the NPM publish action I expected. Guessing that my access to the repo doesn't confer access to the NPM publish token.

We should fix that (might be a manual publish for you @davidar ... sorry!)

We should get v2.0.3 out with #29 included anyway?

@davidar
Copy link
Owner

davidar commented Sep 21, 2021

Oops, sorry for the lack of response. All looks good to me :)

I'll see what I can do about NPM access when I have a chance

@davidar
Copy link
Owner

davidar commented Sep 24, 2021

Ah, I remember, I started setting up the CI integration for publishing, but then wasn't particularly happy that the automation tokens grant unlimited access to my NPM account, hopefully npm/roadmap#10 will be resolved soon

In the meantime I've added you as a maintainer on NPM, is that sufficient?

We should get v2.0.3 out with #29 included anyway?

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants