Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change encode/decode signatures to improve error handling #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Change encode/decode signatures to improve error handling #6

wants to merge 2 commits into from

Conversation

okdistribute
Copy link

Breaking change, will bump to 2.0.0

Fixes #5, see there for discussion.

@okdistribute okdistribute requested a review from Frando January 8, 2021 21:55
@okdistribute okdistribute mentioned this pull request Mar 12, 2021
Open
Frando
Frando requested changes Mar 17, 2021
View reviewed changes
Copy link
Member

@Frando Frando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! The signatures of the new methods look good to me, and now more panic! 😄

I left a few small comments, the main one being that I'd propose to skip the failure dependency and just use a simple custom error type. Otherwise it's good to go for me!

src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frando Frando Frando requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

method signatures
2 participants
@okdistribute @Frando