From 0f9fb0040c50f5ae0ddbd395c33b337abedada35 Mon Sep 17 00:00:00 2001 From: Blake Griffith Date: Thu, 24 Oct 2024 11:35:45 -0400 Subject: [PATCH 1/3] Pin last working version of JS hypercore in tests --- tests/js/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/js/package.json b/tests/js/package.json index 2c5db7da..e5132c99 100644 --- a/tests/js/package.json +++ b/tests/js/package.json @@ -5,6 +5,6 @@ "step": "node interop.js" }, "dependencies": { - "hypercore": "^10" + "hypercore": "10.31.12" } } From 39cb206ed25c029d1c58a8a9acdc2760e50e2051 Mon Sep 17 00:00:00 2001 From: Blake Griffith Date: Thu, 24 Oct 2024 12:11:10 -0400 Subject: [PATCH 2/3] Fix errors in benches --- benches/memory.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/benches/memory.rs b/benches/memory.rs index bb976856..7c916fb8 100644 --- a/benches/memory.rs +++ b/benches/memory.rs @@ -25,7 +25,7 @@ async fn create_hypercore(page_size: usize) -> Result let storage = Storage::open( |_| { Box::pin(async move { - Ok(Box::new(RandomAccessMemory::new(page_size)) as Box) + Ok(Box::new(RandomAccessMemory::new(page_size)) as Box) }) }, false, @@ -44,7 +44,7 @@ async fn create_hypercore(page_size: usize) -> Result let storage = Storage::open( |_| { Box::pin(async move { - Ok(Box::new(RandomAccessMemory::new(page_size)) as Box) + Ok(Box::new(RandomAccessMemory::new(page_size)) as Box) }) }, false, From 60015d77a080fa7315035a175cc876be743329d7 Mon Sep 17 00:00:00 2001 From: Blake Griffith Date: Thu, 24 Oct 2024 12:13:07 -0400 Subject: [PATCH 3/3] run cargo check on all targets To catch problems in errors, benches, and examples --- .github/workflows/ci.yml | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6976e989..a51cf66c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,12 +32,12 @@ jobs: components: rustfmt - name: Run tests run: | - cargo check --no-default-features --features tokio - cargo check --no-default-features --features tokio,sparse - cargo check --no-default-features --features tokio,sparse,cache - cargo check --no-default-features --features async-std - cargo check --no-default-features --features async-std,sparse - cargo check --no-default-features --features async-std,sparse,cache + cargo check --all-targets --no-default-features --features tokio + cargo check --all-targets --no-default-features --features tokio,sparse + cargo check --all-targets --no-default-features --features tokio,sparse,cache + cargo check --all-targets --no-default-features --features async-std + cargo check --all-targets --no-default-features --features async-std,sparse + cargo check --all-targets --no-default-features --features async-std,sparse,cache cargo test --no-default-features --features js_interop_tests,tokio cargo test --no-default-features --features js_interop_tests,tokio,sparse cargo test --no-default-features --features js_interop_tests,tokio,sparse,cache @@ -57,12 +57,12 @@ jobs: components: rustfmt - name: Run tests run: | - cargo check --no-default-features --features tokio - cargo check --no-default-features --features tokio,sparse - cargo check --no-default-features --features tokio,sparse,cache - cargo check --no-default-features --features async-std - cargo check --no-default-features --features async-std,sparse - cargo check --no-default-features --features async-std,sparse,cache + cargo check --all-targets --no-default-features --features tokio + cargo check --all-targets --no-default-features --features tokio,sparse + cargo check --all-targets --no-default-features --features tokio,sparse,cache + cargo check --all-targets --no-default-features --features async-std + cargo check --all-targets --no-default-features --features async-std,sparse + cargo check --all-targets --no-default-features --features async-std,sparse,cache cargo test --no-default-features --features tokio cargo test --no-default-features --features tokio,sparse cargo test --no-default-features --features tokio,sparse,cache @@ -82,12 +82,12 @@ jobs: components: rustfmt - name: Run tests run: | - cargo check --no-default-features --features tokio - cargo check --no-default-features --features tokio,sparse - cargo check --no-default-features --features tokio,sparse,cache - cargo check --no-default-features --features async-std - cargo check --no-default-features --features async-std,sparse - cargo check --no-default-features --features async-std,sparse,cache + cargo check --all-targets --no-default-features --features tokio + cargo check --all-targets --no-default-features --features tokio,sparse + cargo check --all-targets --no-default-features --features tokio,sparse,cache + cargo check --all-targets --no-default-features --features async-std + cargo check --all-targets --no-default-features --features async-std,sparse + cargo check --all-targets --no-default-features --features async-std,sparse,cache cargo test --no-default-features --features js_interop_tests,tokio cargo test --no-default-features --features js_interop_tests,tokio,sparse cargo test --no-default-features --features js_interop_tests,tokio,sparse,cache