Migrate codegen to pure-rust generator #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the build.rs dev dependency to generate protobuf files using a pure-rust implementation, removing the requirement to have `protoc` installed and making it easier to contribute. This commit also bumps the lib protobuf lib to the latest version, and pin it to a specific dependency, as required by the constant it generates. Due to requiring a specific protobuf version, a new minor version has been bumped. Tentatively fix datrs#2
yoshuawuyts
reviewed
Jan 27, 2020
| } | ||
| fn into_any(self: Box<Self>) -> ::std::boxed::Box<::std::any::Any> { | ||
| fn into_any(self: Box<Self>) -> ::std::boxed::Box<dyn (::std::any::Any)> { |
There was a problem hiding this comment.
Did you run cargo fmt on the files? With edition=2018 the ::prefix on paths should have been removed.
There was a problem hiding this comment.
I haven't run anything, just the generation steps from the lib. I could take a look on that later on and try to fix the CI as well
yoshuawuyts
approved these changes
Jan 27, 2020
|
I don't have access here, and I'm not sure how to publish crates either, but I could learn :) |
|
@bltavares I've given you access to both! If you log into crates.io you're now part of the team for https://crates.io/crates/dat-network-protocol 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the build.rs dev dependency to generate protobuf
files using a pure-rust implementation, removing the requirement to have
protocinstalled and making it easier to contribute.This commit also bumps the lib protobuf lib to the latest version, and pin it
to a specific dependency, as required by the constant it generates. Due
to requiring a specific protobuf version, a new minor version has been
bumped.
Tentatively fix #2
Choose one: a 🙋 feature
Checklist
Context
#2
Semver Changes
0.2.0