Skip to content
This repository has been archived by the owner on Feb 24, 2019. It is now read-only.

MINOR issue with SQLInfo.ps1 #74

Open
dbadavekc opened this issue Apr 17, 2017 · 2 comments
Open

MINOR issue with SQLInfo.ps1 #74

dbadavekc opened this issue Apr 17, 2017 · 2 comments

Comments

@dbadavekc
Copy link

dbadavekc commented Apr 17, 2017

Do you want to request a feature or report a bug?
MINOR Bug
What is the current behavior?
Detects SQL Server 2016 as SQL Server 2014
**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net
Running the "dbareports - SQL Server Information" job
What is the expected behavior?
Should detect major version 13 as "SQL 2016", but instead detects as "SQL 2014".
SUPER SIMPLE FIX - just change line 160/161
if ($VersionMajor -eq 13)
{ $Version = 'SQL 2014' }

to:
if ($VersionMajor -eq 13)
{ $Version = 'SQL 2016' }

Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures?
SQL Server 2016. Don't know about previous versions, as I just started using this awesome product!

@dbadavekc
Copy link
Author

Sorry, just realized this is a dupe. However, I am still seeing this behavior with the latest version, pulled today

@jstexasdba
Copy link
Collaborator

Oh, I think I have this as a previous pull request that did not get merged. Let me review the 2 PR's and see which one it is in and then I will Merge it to dev first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants