Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing epoch_sampling_fraction does not support DatasetProcessingParams #422

Closed
WenkelF opened this issue Jul 31, 2023 · 0 comments · Fixed by #414
Closed

Removing epoch_sampling_fraction does not support DatasetProcessingParams #422

WenkelF opened this issue Jul 31, 2023 · 0 comments · Fixed by #414

Comments

@WenkelF
Copy link
Collaborator

WenkelF commented Jul 31, 2023

We remove the epoch_sampling_fraction here:

args = deepcopy(self.task_specific_args)
# pop epoch_sampling_fraction out when creating hash
# so that the data cache does not need to be regenerated
# when epoch_sampling_fraction has changed.
for task in self.task_specific_args.keys():
if "epoch_sampling_fraction" in args[task].keys():
args[task].pop("epoch_sampling_fraction")

However, args[task] is not always a Dict. For instance, in ADMETBenchmarkDataModule, it is a DatasetProcessingParams.

@WenkelF WenkelF linked a pull request Aug 4, 2023 that will close this issue
@cwognum cwognum removed a link to a pull request Aug 4, 2023
@cwognum cwognum linked a pull request Aug 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant