Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

Frontend code should not break if the return route has no trip. It should ignore the route and proceed #697

Open
chuasweechin opened this issue Nov 8, 2018 · 2 comments
Open

Frontend code should not break if the return route has no trip. It should ignore the route and proceed #697

chuasweechin opened this issue Nov 8, 2018 · 2 comments
Assignees
@xkjyeah @joelchoo @chuasweechin

Comments

@chuasweechin
Copy link

image
@chuasweechin chuasweechin changed the title Frontend code should not break if the return route date is incomplete Frontend code should not break if the return route has no trip. It should ignore the route and proceed Nov 8, 2018
@chuasweechin
Copy link
Author

By Daniel: Line of code to fix

beeline-frontend/beeline/services/data/CrowdstartService.js

Line 70 in f729fe1

let firstTripDate = new Date(crowdstart.trips[0].date)

beeline/services/data/CrowdstartService.js:70
let firstTripDate = new Date(crowdstart.trips[0].date)

@chuasweechin
Copy link
Author

chuasweechin commented Nov 8, 2018 •
edited
Loading

As explained, front end should skip routes that do not have any trips. This should apply for booking, tracking and crowd start route

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xkjyeah xkjyeah

@joelchoo joelchoo

@chuasweechin chuasweechin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xkjyeah @joelchoo @chuasweechin