Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotency broken for alerts #195

Open
BaukJ opened this issue Feb 17, 2025 · 0 comments
Open

Idempotency broken for alerts #195

BaukJ opened this issue Feb 17, 2025 · 0 comments

Comments

@BaukJ
Copy link

BaukJ commented Feb 17, 2025

With the latest version of SAT, the idempotency is broken so if we ever re-run the initializer notebook, we re-create all the alerts.
This not only means we end up with lots of old alerts, but also means that any notifications on the alerts we setup manually no longer work.

It looks like a combination of stripping out the preview APIs and moving resources to folders that broke this.

I did take a quick look at fixing this, but it's going to take more time than I thought so I'm not sure if I'll be able to get round to it and we're putting in a workaround for our use-case.
The current alert idempotency code is half commented out, and doesn't work as it uses functionality not present in the API (that I assume was present in the preview API).
If you just fix the alert idempotency code, then the alerts no longer work as each run the folder is deleted. It looks like this deletes the underlying query but not the alert, so by not recreating the alert we end up with a broken alert pointing to a query that no longer exists.

Basically, we'd need to either make sure the queries are not deleted and understand the impact to that, or update the current alerts to use the new query ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant