Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguageVersion should implement relational operators #2014

Open
parlough opened this issue Feb 5, 2025 · 1 comment · May be fixed by #2016
Open

LanguageVersion should implement relational operators #2014

parlough opened this issue Feb 5, 2025 · 1 comment · May be fixed by #2016
Labels
package:package_config

Comments

@parlough
Copy link
Member

parlough commented Feb 5, 2025 •
edited
Loading

It seems packages that rolled their own LanguageVersion often override the relational operators for use when adjusting behavior. I think it's reasonable and is more straightforward than directly using compareTo.

\cc @lrhn for thoughts.
@lrhn
Copy link
Member

lrhn commented Feb 8, 2025

Seems reasonable.

@parlough parlough linked a pull request Feb 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:package_config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[package_config] Implement relational operators for LanguageVersion parlough/dart-tools
2 participants
@lrhn @parlough