Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on pkg/compiler/test/end_to_end/dart2js_batch2_test #59914

Closed
jyameo opened this issue Jan 15, 2025 · 2 comments
Closed

Failures on pkg/compiler/test/end_to_end/dart2js_batch2_test #59914

jyameo opened this issue Jan 15, 2025 · 2 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. gardening triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jyameo
Copy link
Contributor

jyameo commented Jan 15, 2025

There are new test failures on [analysis_server] Move all EditableArgument tests to a shared mixin and run for legacy...[analysis_server] Add a shared test interface to simplify sharing tests between LSP, LSP-over-Legacy.

The tests

pkg/compiler/test/end_to_end/dart2js_batch2_test RuntimeError (expected Pass)

are failing on configurations

web-unittest-asserts-linux

LOG: https://dart-ci.appspot.com/log/dart2js-unit-linux-x64-release/web-unittest-asserts-linux/27569/pkg/compiler/test/end_to_end/dart2js_batch2_test
@jyameo jyameo changed the title Failures on [analysis_server] Move all EditableArgument tests to a shared mixin and run for legacy...[analysis_server] Add a shared test interface to simplify sharing tests between LSP, LSP-over-Legacy Failures on pkg/compiler/test/end_to_end/dart2js_batch2_test Jan 15, 2025
@dart-github-bot
Copy link
Collaborator

Summary: Dart2JS end-to-end tests (dart2js_batch2_test) are failing on Linux in the web-unittest-asserts configuration. The failures are related to recent changes in the analysis server.

@dart-github-bot dart-github-bot added area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jan 15, 2025
@biggs0125
Copy link

It looks like this was just an intermittent infra flake. The test is passing on all configs now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. gardening triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@biggs0125 @jyameo @dart-github-bot