From aa6ed3fff7bfbeb35c303d9616fc056c575b4dd0 Mon Sep 17 00:00:00 2001 From: Jens Johansen Date: Thu, 12 Dec 2024 23:08:49 -0800 Subject: [PATCH] [vm_service] Renamed badly named tests to _test.dart We've accumulated some tests that wasn't named as such, thus not actually being run. Change-Id: Ia42a99de14312af6f7b3ddfa5a107b74bf5ae663 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400320 Reviewed-by: Derek Xu Commit-Queue: Jens Johansen --- pkg/pkg.status | 1 + ...ethod.dart => eval_inside_extension_type_method_test.dart} | 3 ++- ...n_extension_type.dart => eval_on_extension_type_test.dart} | 3 ++- ...al_skip_breakpoint.dart => eval_skip_breakpoint_test.dart} | 2 +- ...ry_usage.dart => get_isolate_group_memory_usage_test.dart} | 4 ++-- ..._skip_breakpoint.dart => invoke_skip_breakpoint_test.dart} | 2 +- 6 files changed, 9 insertions(+), 6 deletions(-) rename pkg/vm_service/test/{eval_inside_extension_type_method.dart => eval_inside_extension_type_method_test.dart} (96%) rename pkg/vm_service/test/{eval_on_extension_type.dart => eval_on_extension_type_test.dart} (97%) rename pkg/vm_service/test/{eval_skip_breakpoint.dart => eval_skip_breakpoint_test.dart} (97%) rename pkg/vm_service/test/{get_isolate_group_memory_usage.dart => get_isolate_group_memory_usage_test.dart} (90%) rename pkg/vm_service/test/{invoke_skip_breakpoint.dart => invoke_skip_breakpoint_test.dart} (96%) diff --git a/pkg/pkg.status b/pkg/pkg.status index 45788777e77c..f87d5db04c7e 100644 --- a/pkg/pkg.status +++ b/pkg/pkg.status @@ -161,6 +161,7 @@ vm_service/test/issue_27238_test: SkipByDesign # Debugger is disabled in AOT mod vm_service/test/issue_27287_test: SkipByDesign # Debugger is disabled in AOT mode. vm_service/test/issue_30555_test: SkipByDesign # Debugger is disabled in AOT mode. vm_service/test/issue_56911_test: SkipByDesign # Debugger is disabled in AOT mode. +vm_service/test/issue_59661_test: SkipByDesign # Debugger is disabled in AOT mode. vm_service/test/kill_paused_test: SkipByDesign # Debugger is disabled in AOT mode. vm_service/test/library_dependency_test: SkipByDesign # Uses 'dart:mirrors' library. vm_service/test/local_variable_declaration_test: SkipByDesign # Debugger is disabled in AOT mode. diff --git a/pkg/vm_service/test/eval_inside_extension_type_method.dart b/pkg/vm_service/test/eval_inside_extension_type_method_test.dart similarity index 96% rename from pkg/vm_service/test/eval_inside_extension_type_method.dart rename to pkg/vm_service/test/eval_inside_extension_type_method_test.dart index 0b6dfcc293e5..e11e9b5e3cde 100644 --- a/pkg/vm_service/test/eval_inside_extension_type_method.dart +++ b/pkg/vm_service/test/eval_inside_extension_type_method_test.dart @@ -21,6 +21,7 @@ extension type Foo(int value) { debugger(); print("This foos value is '$value'"); } + int otherCall() { return value * 2; } @@ -64,6 +65,6 @@ final testSteps = [ Future main([args = const []]) => runIsolateTests( args, testSteps, - 'eval_inside_extension_type_method.dart', + 'eval_inside_extension_type_method_test.dart', testeeConcurrent: testFunction, ); diff --git a/pkg/vm_service/test/eval_on_extension_type.dart b/pkg/vm_service/test/eval_on_extension_type_test.dart similarity index 97% rename from pkg/vm_service/test/eval_on_extension_type.dart rename to pkg/vm_service/test/eval_on_extension_type_test.dart index 56218d813706..bb00fca3eb4e 100644 --- a/pkg/vm_service/test/eval_on_extension_type.dart +++ b/pkg/vm_service/test/eval_on_extension_type_test.dart @@ -23,6 +23,7 @@ extension type Foo(int value) { void printFoo() { print("This foos value is '$value'"); } + int otherCall() { return value * 2; } @@ -66,6 +67,6 @@ final testSteps = [ Future main([args = const []]) => runIsolateTests( args, testSteps, - 'eval_on_extension_type.dart', + 'eval_on_extension_type_test.dart', testeeConcurrent: testFunction, ); diff --git a/pkg/vm_service/test/eval_skip_breakpoint.dart b/pkg/vm_service/test/eval_skip_breakpoint_test.dart similarity index 97% rename from pkg/vm_service/test/eval_skip_breakpoint.dart rename to pkg/vm_service/test/eval_skip_breakpoint_test.dart index 9152292ebd58..ef0ddc2932a1 100644 --- a/pkg/vm_service/test/eval_skip_breakpoint.dart +++ b/pkg/vm_service/test/eval_skip_breakpoint_test.dart @@ -57,6 +57,6 @@ final tests = [ void main([args = const []]) => runIsolateTests( args, tests, - 'eval_skip_breakpoint.dart', + 'eval_skip_breakpoint_test.dart', testeeConcurrent: testMain, ); diff --git a/pkg/vm_service/test/get_isolate_group_memory_usage.dart b/pkg/vm_service/test/get_isolate_group_memory_usage_test.dart similarity index 90% rename from pkg/vm_service/test/get_isolate_group_memory_usage.dart rename to pkg/vm_service/test/get_isolate_group_memory_usage_test.dart index 36e6074b083e..0dd9b7ec4ff6 100644 --- a/pkg/vm_service/test/get_isolate_group_memory_usage.dart +++ b/pkg/vm_service/test/get_isolate_group_memory_usage_test.dart @@ -26,7 +26,7 @@ var tests = [ expect( e.details, contains( - "getMemoryUsage: invalid 'isolateGroupId' parameter: badid", + "getMemoryUsage: invalid 'isolateId' parameter: badid", ), ); } @@ -37,5 +37,5 @@ var tests = [ void main([args = const []]) => runVMTests( args, tests, - 'get_isolate_group_memory_usage.dart', + 'get_isolate_group_memory_usage_test.dart', ); diff --git a/pkg/vm_service/test/invoke_skip_breakpoint.dart b/pkg/vm_service/test/invoke_skip_breakpoint_test.dart similarity index 96% rename from pkg/vm_service/test/invoke_skip_breakpoint.dart rename to pkg/vm_service/test/invoke_skip_breakpoint_test.dart index e72140845ce1..6d740f3f88b7 100644 --- a/pkg/vm_service/test/invoke_skip_breakpoint.dart +++ b/pkg/vm_service/test/invoke_skip_breakpoint_test.dart @@ -51,6 +51,6 @@ final tests = [ void main([args = const []]) => runIsolateTests( args, tests, - 'invoke_skip_breakpoint.dart', + 'invoke_skip_breakpoint_test.dart', testeeConcurrent: testMain, );