From 61336f32ab43c11747eb22ff6d1ca91c38b987c6 Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Tue, 14 Jan 2025 05:20:33 -0800 Subject: [PATCH] [dart2wasm] Mark timing out test as SkipSlow on all browsers, not just Chrome MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The root cause is that an `asyncEnd()` doesn't get executed which will make the test not print `unittest-suite-success` which will make the test controller keep waiting indefinitly until the test times out. => This is true on all browsers, not just Chrome Though commandline JS engines don't have this problem as they will simply exit once there's no longer work and event loop is empty. => Here the test runner will recognize the missing `unittest-suite-success` and report the tests as failing. Issue https://github.com/dart-lang/sdk/issues/55182 Change-Id: Id217e9bd715d99f9927e7e18b03385aa2880b27f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404107 Reviewed-by: Ömer Ağacan Commit-Queue: Martin Kustermann --- tests/co19/co19-dart2wasm.status | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/co19/co19-dart2wasm.status b/tests/co19/co19-dart2wasm.status index 8e96ee9d4f9d..6e7acf4139d3 100644 --- a/tests/co19/co19-dart2wasm.status +++ b/tests/co19/co19-dart2wasm.status @@ -15,5 +15,5 @@ LibTest/io/*: SkipByDesign # dart:io is not supported. LibTest/isolate/*: SkipByDesign # dart:isolate is not supported. LibTest/mirrors/*: SkipByDesign # dart:mirrors is not supported. -[ $compiler == dart2wasm && $runtime == chrome ] -Language/Expressions/Function_Invocation/async_generator_invokation_t10: SkipSlow # Issue(http://dartbug.com/55025) +[ $compiler == dart2wasm && $browser ] +Language/Expressions/Function_Invocation/async_generator_invokation_t10: SkipSlow # Issue(http://dartbug.com/55182): Will timeout on browsers (due to no asyncEnd() firing) but eagerly fail on commandline JS engines.