Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OM SYSTEM OM1 Mark II #16297

Closed
philippeg2 opened this issue Feb 11, 2024 · 24 comments
Closed

OM SYSTEM OM1 Mark II #16297

philippeg2 opened this issue Feb 11, 2024 · 24 comments
Assignees
Labels
incomplete pull request needing changes to be merged scope: camera support adding WB and raw support for new cameras

Comments

@philippeg2
Copy link

I have no sample yes because i did not buy the yet but raw can find here

https://www.dpreview.com/sample-galleries/0739659306/om-system-om-1-sample-gallery

@philippeg2 philippeg2 added the scope: camera support adding WB and raw support for new cameras label Feb 11, 2024
@kmilos
Copy link
Contributor

kmilos commented Feb 11, 2024

We’ll need the CC0 contributed samples first I’m afraid.

Edit: from reading the manual, all of these are expected:

"Regular" 20M ORF raw (high res mode off)
High res handheld 50M raw (both combined ORF and single frame reference ORI)
High res tripod 80M raw (both combined ORF and single frame reference ORI)

In addition, looks like the high res ones can also be set for either 12 or 14 bit depth, so 9 samples in total.

@LebedevRI LebedevRI added the incomplete pull request needing changes to be merged label Feb 11, 2024
@mguzmann
Copy link

I'll get this camera in a couple of days, I'll be happy to provide some raw files. Could you maybe tell me in more detail what sorts of raw files you'd need, how should they be shot?

@kmilos
Copy link
Contributor

kmilos commented Feb 16, 2024

Could you maybe tell me in more detail what sorts of raw files you'd need, how should they be shot?

https://raw.pixls.us/
https://github.com/darktable-org/darktable/wiki/Camera-support
https://discuss.pixls.us/t/raw-samples-wanted/5420

Thanks

@krid
Copy link

krid commented Feb 28, 2024

I just uploaded nine RAW samples from my day-old OM-1 MkII to https://raw.pixls.us/. They're pictures of my back yard: f8, 25mm, mix of sun & shade, lots of branches. I believe I covered all the permunations & combitations of resolution & bit-depth.

They don't show up in the repository list yet, but I assume that's because they need some vetting/processing. Please let me know if they're sufficient/useful.

@LebedevRI
Copy link
Member

@krid thank you for the contribution! verified all 9 samples...

@krid
Copy link

krid commented Feb 28, 2024

I will try to muster up the patience to do the WB, noise, and basecurve shoots. maybe when it's raining this weekend. I don't have a proper color chart so I'll pass on the profiling part.

@kmilos
Copy link
Contributor

kmilos commented Feb 28, 2024

Thanks for the samples! If you feel up to it, you can test darktable-org/rawspeed#677

The basecurve workflow is deprecated, color calibration and chart module replace the custom colour profile, so only WB presets and noise profile are welcome additions.

@LebedevRI
Copy link
Member

50mp-14bit-handheld.orf and 80mp-14bit-tripod.orf don't successfully decode, which is a weird combination.

@kmilos
Copy link
Contributor

kmilos commented Feb 28, 2024

Those are new modes I guess, AFAIK the original OM-1 didn't do 14b...

@krid
Copy link

krid commented Feb 28, 2024

What do you mean by "don't successfully decode"? Like the files are borked and I should shoot new ones, or there's something wrong on the rawspeed/darktable end?

@LebedevRI
Copy link
Member

Those are new modes I guess, AFAIK the original OM-1 didn't do 14b...

I mean, i'm surprised that out of four samples that are 14-bit, only these two don't work.

What do you mean by "don't successfully decode"? Like the files are borked and I should shoot new ones, or there's something wrong on the rawspeed/darktable end?

I don't know yet.

@kmilos
Copy link
Contributor

kmilos commented Feb 28, 2024

I mean, i'm surprised that out of four samples that are 14-bit, only these two don't work.

I would think the "14b" ORIs matching those are still 12b.

@krid
Copy link

krid commented Feb 28, 2024

Last night I manually made the edits for 677 to my cameras.xml, but for some reason the test shot I used came up solid black. I tried it this morning with the back-yard shots and those (well, the 12 bit ones) work fine. I ran the three ORF files through and now I've got three perfectly boring JPGs of my back yard.
A 14 bit shot gives me the big white skull, but I can live w/o those for now.
Looks like the answer to the "how soon will Darktable support my camera" question is "Now!".

@krid
Copy link

krid commented Feb 28, 2024

Let me know if you need more 14 bit samples. I can do those along with the WB and noise shots. Heck, I can do 14 bit noise samples if you want (though that probably doesn't make sense).

@LebedevRI
Copy link
Member

Ok, got a heuristic to explicitly bail on those, will merge that PR soon(TM).

@LebedevRI
Copy link
Member

Ok, if you can build dt locally, update git rawspeed submodule to use develop branch, and it'll work.

for some reason the test shot I used came up solid black

There's some race conditions in dt, that is one of the symptoms.

@krid
Copy link

krid commented Feb 28, 2024

Ok, if you can build dt locally, update git rawspeed submodule to use develop branch, and it'll work.

Never tried building Darktable, but how hard can it be? Looks like my rainy weekend is going to be busy with Darktable stuff...

@kmilos
Copy link
Contributor

kmilos commented Feb 29, 2024

I mean, i'm surprised that out of four samples that are 14-bit, only these two don't work.

I would think the "14b" ORIs matching those are still 12b.

Yep, found this in the exiftool output for all ORIs:

[Olympus]       ValidBits                       : 12 0

Makes sense, as this is the native sensor format for a single frame, the others are a result of combining multiple ones. For the 14b high-res ORFs this is, as expected, 14 (as you've found already).

@mlouielu
Copy link
Contributor

Hi all, I tried it today and it works with rawspeed/develop for 12-bits photos. But how can I modify or update the code for lens corrections and denoise (profile)? Can you point me out what should I do? Thanks!

@kmilos
Copy link
Contributor

kmilos commented Mar 19, 2024

@mlouielu See https://github.com/darktable-org/darktable/wiki/Camera-support

@mlouielu
Copy link
Contributor

@mlouielu See https://github.com/darktable-org/darktable/wiki/Camera-support

For noise profile, if I have a OLED screen, can I just put the gradient on the screen with black background? Since the black on OLED is black without backlight.

@kmilos
Copy link
Contributor

kmilos commented Mar 19, 2024

For noise profile, if I have a OLED screen, can I just put the gradient on the screen with black background? Since the black on OLED is black without backlight.

I think not a problem, the whole point is to get enough pixels throughout the whole range. @rawfiner For any further questions, please follow up on the article discussion directly.

@kmilos kmilos moved this from Incomplete to Requires New Raw Format Support in New Camera Support Mar 26, 2024
@github-project-automation github-project-automation bot moved this from Requires New Raw Format Support to Resolved in New Camera Support Apr 2, 2024
@krid
Copy link

krid commented Apr 2, 2024

What is the status of 14-bit support? Looks like it's still excluded. Should I file a separate bug for that?

@kmilos
Copy link
Contributor

kmilos commented Apr 3, 2024

Should I file a separate bug for that?

It's already tracked: darktable-org/rawspeed#686

LebedevRI added a commit that referenced this issue Apr 3, 2024
Merge remote-tracking branch 'upstream/develop' into stable

* Make Olympus decompressor faster (-13%)
* Make Sony LJpeg decompressor faster (-33%)
* Support broken-by-design Blackmagic uncompressed DNG's. Refs. #11495.

* OM System OM-1 Mark II support. Fixes #16297.
* Fujifilm X100VI support. Fixes #16393.
* Sony ILCE-9M3 support. Fixes #16523.
* Phase One P25+ support. Fixes #16539.
* Add Panasonic DC-TZ95D alias. Fixes #16353.
* Remove explicit crop from Fujifilm X-Trans gen-4/5 cameras. Fixes #5729.
* Leica SL3 normalization
* Fix up Panasonic DMC-FZ28 crop modes. Fixes #16457.

* Add unsupported Panasonic placeholders
* Add unsupported Canon placeholders
* Add Fujifilm X100VI placeholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete pull request needing changes to be merged scope: camera support adding WB and raw support for new cameras
Projects
Status: Resolved
Development

No branches or pull requests

6 participants