From e2135b4aa3e50ec0b4f217bc32c85222e9ac1d5f Mon Sep 17 00:00:00 2001 From: Elena Kolevska Date: Wed, 1 Nov 2023 15:20:08 +0000 Subject: [PATCH 1/2] Removes test comments Signed-off-by: Elena Kolevska --- tests/conf/helpers_test.py | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/conf/helpers_test.py b/tests/conf/helpers_test.py index 90aa8166..6f0459f4 100644 --- a/tests/conf/helpers_test.py +++ b/tests/conf/helpers_test.py @@ -137,21 +137,13 @@ def test_parse_grpc_endpoint(self): ] for testcase in testcases: - # if testcase["error"]: - # with self.assertRaises(ValueError): - # GrpcEndpoint(testcase["url"]) - # else: - # url = GrpcEndpoint(testcase["url"]) - # assert url.endpoint == testcase["endpoint"] - # assert url.tls == testcase["secure"] - # assert url.hostname == testcase["host"] - # assert url.port == str(testcase["port"]) - try: + if testcase["error"]: + with self.assertRaises(ValueError): + GrpcEndpoint(testcase["url"]) + else: url = GrpcEndpoint(testcase["url"]) - print(f'{testcase["url"]}\t {url.endpoint} \t{url.hostname}\t{url.port}\t{url.tls}') assert url.endpoint == testcase["endpoint"] assert url.tls == testcase["secure"] assert url.hostname == testcase["host"] assert url.port == str(testcase["port"]) - except ValueError as error: - print(f'{testcase["url"]}\t \t\t\t\t Error: {error}') + From e8a838f60889ac7906d8a1ee352b668f58507259 Mon Sep 17 00:00:00 2001 From: Elena Kolevska Date: Wed, 1 Nov 2023 15:25:48 +0000 Subject: [PATCH 2/2] Removes blank line Signed-off-by: Elena Kolevska --- tests/conf/helpers_test.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/conf/helpers_test.py b/tests/conf/helpers_test.py index 6f0459f4..66c937ff 100644 --- a/tests/conf/helpers_test.py +++ b/tests/conf/helpers_test.py @@ -146,4 +146,3 @@ def test_parse_grpc_endpoint(self): assert url.tls == testcase["secure"] assert url.hostname == testcase["host"] assert url.port == str(testcase["port"]) -