Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): runtime rc8 with cli rc3 #769

Closed
wants to merge 4 commits into from

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Jan 22, 2025

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Mike Nguyen <[email protected]>
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.15@998c134). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.15     #769   +/-   ##
===============================================
  Coverage                ?   86.29%           
===============================================
  Files                   ?       89           
  Lines                   ?     5029           
  Branches                ?        0           
===============================================
  Hits                    ?     4340           
  Misses                  ?      689           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump to the latest rc

.github/workflows/validate_examples.yaml Outdated Show resolved Hide resolved
.github/workflows/validate_examples.yaml Outdated Show resolved Hide resolved
.github/workflows/validate_examples.yaml Outdated Show resolved Hide resolved
@elena-kolevska elena-kolevska changed the title test: rc5 with cli rc1 test: rc7 with cli rc3 Jan 28, 2025
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping to rc8

.github/workflows/validate_examples.yaml Outdated Show resolved Hide resolved
.github/workflows/validate_examples.yaml Outdated Show resolved Hide resolved
@elena-kolevska
Copy link
Contributor

All tests are passing with rc8 🎉

@mikeee mikeee marked this pull request as ready for review January 30, 2025 09:19
@mikeee mikeee requested review from a team as code owners January 30, 2025 09:19
@mikeee mikeee changed the title test: rc7 with cli rc3 chore(ci): runtime rc8 with cli rc3 Jan 30, 2025
@elena-kolevska
Copy link
Contributor

We don't need to actually merge this PR (it was useful for triggering tests with new RCs) because the workflow gets the latest version from helm for runtime and from github for the cli.

@mikeee mikeee closed this Jan 30, 2025
@mikeee mikeee deleted the testing/1.15-validation branch January 30, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants