Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes grpc and grpcs from the accepted schemes list #700

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

elena-kolevska
Copy link
Contributor

Description

grpc and grpcs are not valid schemes, as per the gRPC name resolution spec and they're not included in our test matrix, but they were mistakenly left over in the accepted schemes list.

@elena-kolevska elena-kolevska requested review from a team as code owners April 24, 2024 10:48
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (fc0e9d1) to head (b75de1a).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
- Coverage   86.37%   86.28%   -0.09%     
==========================================
  Files          79       82       +3     
  Lines        4094     4172      +78     
==========================================
+ Hits         3536     3600      +64     
- Misses        558      572      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elena-kolevska elena-kolevska mentioned this pull request Apr 24, 2024
3 tasks
@berndverst berndverst merged commit 15d0573 into dapr:main Apr 30, 2024
3 of 7 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @elena-kolevska 😁

Copy link

holopin-bot bot commented May 7, 2024

Congratulations @elena-kolevska, you just earned a badge! Here it is: https://holopin.io/claim/clvwgc045129650fjmlk8dbky4

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants