Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WORKFLOW SDK BUG] None Check is missing in the WorkflowState to_json #691

Closed
amichel opened this issue Apr 2, 2024 · 3 comments · Fixed by #707
Closed

[WORKFLOW SDK BUG] None Check is missing in the WorkflowState to_json #691

amichel opened this issue Apr 2, 2024 · 3 comments · Fixed by #707
Labels

Comments

@amichel
Copy link

amichel commented Apr 2, 2024

Expected Behavior

Always get a valid JSON using the to_json method

Actual Behavior

When workflow completes successfully, to_json (and str) methods fail with
Exception calling application: 'NoneType' object has no attribute 'message'

Steps to Reproduce the Problem

  1. Run any Workflow to completion, such that failure_details is absent from the workflow state.
  2. Call either get_state or wait_for_workflow_completion
  3. Call to_json on the returned state object

Release Note

RELEASE NOTE:

@elena-kolevska
Copy link
Contributor

LGTM. It's a simple enough change, I also confirmed it locally, but I would feel better if we added a little test for it, though.

@berndverst
Copy link
Member

@akshaya-a please reply on this issue with /assign to get credit for addressing it.

@berndverst berndverst modified the milestones: v1.14, workflow-0.5.0 Jun 26, 2024
@berndverst
Copy link
Member

dapr-ext-workflow release candidate version v0.5.0rc1 with this change is now released. FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants