Removes explicit dapr stop
from examples for short-running apps
#674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While validating the 1.13 rc1 I ran into the following 3 issues:
./validate.sh invoke-custom-data
(❌ failed to stop app id invoke-caller: couldn't find app id invoke-caller)./validate.sh w3c-tracing
(❌ failed to stop app id invoke-caller: couldn't find app id invoke-caller)./validate.sh demo_workflow
(❌ details = "error starting workflow 'hello_world_wf': unable to start workflow: failed to start orchestration: error from internal actor: an active workflow with ID 'exampleInstanceID' already exists"== APP == debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:50001 {created_time:"2024-02-14T14:14:09.774273+00:00", grpc_status:13, grpc_message:"error starting workflow 'hello_world_wf': unable to start workflow: failed to start orchestration: error from internal actor: an active workflow with ID 'exampleInstanceID' already exists"}")
This PR addresses the first two issues. The reason for this is a change of behaviour in Dapr, which now properly catches
SIGTERM
signals. The examples usedapr run
to run the apps and the dapr cli sends aSIGTERM
when an application finishes execution. That's why the tests broke now.This behaviour is only evident for short-running scripts.
I updated the examples to not try to stop the dapr instance explicitly.
Checklist