Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample k8s config using wrong port. #592

Closed
softnado opened this issue Aug 19, 2023 · 2 comments · Fixed by #640
Closed

Sample k8s config using wrong port. #592

softnado opened this issue Aug 19, 2023 · 2 comments · Fixed by #640
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@softnado
Copy link

Should the port mentioned here be 50051?

@berndverst
Copy link
Member

berndverst commented Sep 11, 2023

EDIT: based on the other files in this example - I think I agree with changing the containerPort here to 50051 instead. Please feel free to submit the PR to change this.

The kubernetes deployment files aren't usually tested so I'm not surprised this mistake snuck in there, but the grpc proxying example is tested without Kubernetes as part of our CI.

@berndverst berndverst added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 8, 2023
@dasanind
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants