-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
high priority class name recommendation #4178
high priority class name recommendation #4178
Conversation
Signed-off-by: Filinto Duran <filinto@diagrid.io>
Signed-off-by: Filinto Duran <filinto@diagrid.io>
Signed-off-by: Filinto Duran <filinto@diagrid.io>
bf0bf34
to
f2bc026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial review
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filintod - Please review my feedback/comments
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
For a new Dapr deployment, this priority class can be set with both the Dapr CLI and Helm charts, | ||
using the helm `--set global.priorityClassName=system-cluster-critical` argument. | ||
|
||
#### Dapr version < 1.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question. Why version 1.14 and below? What is different from 1.14 onwards, is this set for you by default? It does not say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 1.14 chart now adds this automatically for the user.
…roduction.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
…roduction.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Filinto Duran <duranto@gmail.com>
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/hosting/kubernetes/kubernetes-production.md
Outdated
Show resolved
Hide resolved
…roduction.md Signed-off-by: Mark Fussell <markfussell@gmail.com>
…roduction.md Signed-off-by: Mark Fussell <markfussell@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@holopin-bot @filintod Thanks Filinto! |
Congratulations @filintod, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv8qxyb45450cjvgq2zt07q This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Following PR for critical priority class resourcequota that needs to be merged first dapr/dapr#7784
Issue reference
To Add after dapr/dapr#7784