Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for Dapr CLI to add/get secrets from secret store component #742

Closed
AaronCrawfis opened this issue Jun 15, 2021 · 11 comments
Closed
Labels

Comments

@AaronCrawfis
Copy link
Contributor

AaronCrawfis commented Jun 15, 2021

Describe the proposal

Dapr CLI should have a command like dapr secrets to add/put secrets from a secret store component. Something like:

dapr secrets add --data '{"connectionString":"343ab342c34a2"}'
dapr secrets add --data-file ./mysecrets.json
dapr secrets get --key "connectionString"

With dapr/dapr#3301 the set secret command should work with any secret component.

Without a POST API, the CLI set command add and get commands should interact with the local JSON file created by #741

Release Note

RELEASE NOTE: ADD new secrets command to get/set secrets from a local JSON secret store

@AaronCrawfis AaronCrawfis added kind/feature New feature or request area/cli P2 labels Jun 15, 2021
@AaronCrawfis
Copy link
Contributor Author

Pairs with #741 to improve secrets management for Dapr

@wcs1only
Copy link
Contributor

I like this idea, but I think it should probably be write only. We add the CLI to simplify adding secrets, that can then only be read by the Dapr secrets API.

@AaronCrawfis
Copy link
Contributor Author

Depends on dapr/dapr#3301

@AaronCrawfis
Copy link
Contributor Author

I like this idea, but I think it should probably be write only. We add the CLI to simplify adding secrets, that can then only be read by the Dapr secrets API.

I actually think adding the ability to get secrets from the CLI would be a useful inner loop feature. Component scoping can allow CLI access to be disabled in production scenarios

@philliphoff
Copy link
Contributor

philliphoff commented Jun 16, 2021

Also a dapr secrets list which returns the known keys (which can then be retrieved using dapr secrets get). It's often useful for developers (and their tools) to be able see values as their application sees them rather than have to dig through the the various backing stores to uncover them.

@AaronCrawfis
Copy link
Contributor Author

AaronCrawfis commented Jun 23, 2021

Mockup for local file
image

@AaronCrawfis
Copy link
Contributor Author

Mockup for any secret store
image

@AaronCrawfis
Copy link
Contributor Author

Based on feedback from this morning it sounds like dapr user-secrets is the preferred command to indicate this is for local development only.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Jan 4, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Feb 3, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Feb 3, 2022
@dapr-bot
Copy link
Collaborator

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants