Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful error when initializing Dapr using a non-moby Docker context #459

Open
philliphoff opened this issue Sep 10, 2020 · 4 comments
Open
Labels
kind/bug Something isn't working triaged/resolved The issue has been triaged

Comments

@philliphoff
Copy link
Contributor

philliphoff commented Sep 10, 2020

Expected Behavior

When attempting to initialize Dapr using a non-moby Docker context, the user should get an error like "Dapr isn't supported in the current Docker context".

Actual Behavior

Dapr returns the following error:

⌛  Making the jump to hyperspace...
❌  unable to confirm whether dapr_zipkin is running or exists. error
unknown flag: --filter

The reason is that certain types of Docker contexts (e.g. ACI) support only a subset of the traditional Docker CLI arguments. In this case, ACI contexts do not support the --filter argument on the docker ps command (used by Dapr to determine whether its components are already running).

Note: ACI contexts are currently in beta, so perhaps it might eventually support --filter and make this issue moot. Alternatively, Docker may improve the error message in this case to better describe the limitations of the current context (as it does when, say, executing docker images in an ACI context.) Still, when the Docker commands are hidden from the user (as is the case here with Dapr) it may still be useful to recognize and trap certain kinds of errors in order to provide a better, more actionable, error.

One could argue this is just an "enhancement", in that I'm really looking for a better error message. However, I labeled it a "bug" as the dapr init command exposes an implementation detail in this error case that's confusing to users who may not understand how Docker is being used under the covers.

Steps to Reproduce the Problem

  1. Install the latest Edge version (e.g. 2.3.6.1) of Docker.
  2. Create and switch to an ACI Docker context (see guide).
  3. Run dapr init.
@philliphoff philliphoff added the kind/bug Something isn't working label Sep 10, 2020
@mukundansundar
Copy link
Collaborator

@yaron2 I think we might potentially need to wrap docker errors properly for the Dapr CLI. I think this should be prioritized for next milestone.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Jan 4, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added stale and removed stale labels Jan 4, 2022
@dapr-bot
Copy link
Collaborator

dapr-bot commented Feb 3, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Feb 3, 2022
@dapr-bot
Copy link
Collaborator

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@mukundansundar mukundansundar added triaged/resolved The issue has been triaged and removed stale labels Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triaged/resolved The issue has been triaged
Projects
None yet
Development

No branches or pull requests

3 participants