-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] optifine lightning #13
Comments
Strange, I guess optifine completely ignores and replaces Minecraft's native lighting updates(?). I wonder if placing and removing a torch next to it would cause an update. |
@dannydjdk yes it cause an update. (edit: or not?) |
Optifine is ignoring the WorldLightManager's checkBlock() method. |
@dannydjdk sleep is important! |
Just as a question to myself (so as a note): Is it possible to use blockstates to display the current light intensity? |
We are overriding the Block's getLightValue(BlockState state, IBlockReader world, BlockPos pos) which is what vanilla Minecraft uses to get the light level for the BlockState. It seems as if Optifine is honoring that. It just isn't honoring the call to the WorldLightManager's checkBlock() method. So, it doesn't update the lighting when it's supposed to, but when it does decide to update the lighting, it seems that it's doing that correctly. Right? |
Yes, I know. Optifine is evil.
Currently, the light output does not work with optifine.
I think it is a wontfix.
I'll still see if I can find something about it and if so I'll try to fix it myself. But it's unlikely, as I have no idea about either optifine or forge.
But maybe I'll find something anyway.
The text was updated successfully, but these errors were encountered: