Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title case is currently not title case #169

Closed
hipsterjazzbo opened this issue Oct 8, 2017 · 1 comment
Closed

Title case is currently not title case #169

hipsterjazzbo opened this issue Oct 8, 2017 · 1 comment

Comments

@hipsterjazzbo
Copy link

The current implementation of title case is not actual title case, in the sense that it simply capitalises each word. Notwithstanding the ability to set $ignore words, I think we could do better.

I have ported John Gruber's title casing script to PHP; would you accept a PR altering the toTitleCase method to use this technique?
@hipsterjazzbo
Copy link
Author

Went ahead and opened a PR anyway :) #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hipsterjazzbo