Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate debugger-caused-leak fix in V8 #183

Open
danfuzz opened this issue Apr 20, 2023 · 2 comments
Open

Validate debugger-caused-leak fix in V8 #183

danfuzz opened this issue Apr 20, 2023 · 2 comments
Labels
bug Something isn't working framework Has something to do with the system framework

Comments

@danfuzz
Copy link
Owner

danfuzz commented Apr 20, 2023

Describe the bug

This project ran across the bug described in https://bugs.chromium.org/p/v8/issues/detail?id=13891. As of this writing, It seems to be fixed, in some form, but it's not yet closed in the Chromium issue tracker, nor (obviously) is there a Node release with the fix.

Once there is in fact a Node release, we should verify the fix by undoing the workaround in EventSink.js, and doing heap dumps with a debugger attached.

Environment

  • OS: n/a
  • Node: not claimed fixed as of 20.0
@danfuzz danfuzz added bug Something isn't working framework Has something to do with the system framework labels Apr 20, 2023
@danfuzz
Copy link
Owner Author

danfuzz commented May 9, 2024

The bug I filed was duped into https://issues.chromium.org/issues/42203677. That bug is listed as still open, but based on the linked test case which runs in your local browser, it looks like the bug is actually fixed. Unclear when, and so also unclear if Node would have picked up the fix yet.

@danfuzz
Copy link
Owner Author

danfuzz commented May 9, 2024

I just did a test with Node v22, and it looks like the problem is fixed there. Unfortunately, we can't rely on v22 being available everywhere we want to run, yet, so I'm leaving this issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Has something to do with the system framework
Projects
None yet
Development

No branches or pull requests

1 participant