Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox table2clipboard extension not compartable with e10s (multi-process) #1

Open
MurzNN opened this issue Nov 29, 2016 · 19 comments

Comments

@MurzNN
Copy link

MurzNN commented Nov 29, 2016

Seems that table2clipboard Firefox extension is not compartable with e10s (multi-process) - it not working with enabled multi-process (menu item is disappear). Can you update for support this mode?

@dafi
Copy link
Member

dafi commented Feb 5, 2017

Hi, making T2C working with new extension model is pretty impossible so I suppose this extension will die

I hope to find a compromise to make it usable but it's really hard

@MurzNN
Copy link
Author

MurzNN commented Feb 6, 2017

Thanks for reply, seems that you must use WebExtensions API for new Firefox versions support.

Maybe you can look at Chome extensions that provide same functional?

Here is some examples:
https://chrome.google.com/webstore/detail/columncopy/lapbbfoohlcmlbdaakldmmallcbcbpjb?hl=en-US
https://chrome.google.com/webstore/detail/table-capture/iebpjdmgckacbodjpijphcplhebcmeop?hl=en-US
https://chrome.google.com/webstore/detail/copy-vertically-on-html-t/nojhhcfadghbjammgogoepokijaaihcb?hl=en-US

Also another Firefox extension https://addons.mozilla.org/en-US/firefox/addon/tabletools2/ works well in Firefox 53 alpha - show menu item, but Table2Clipboard not show menu item.

@bbayles
Copy link

bbayles commented Jun 14, 2017

I've loved Table2Clipboard for many years, so I'm hoping there will be a way to port it to the new model. As above, the Table Capture Chrome extension is explicitly inspired by T2C, so I hope it shows a way forward.

Many thanks for making this extension!

@markusb68
Copy link

Setting browser.tabs.remote.force-enable to false enables t2c again. but may break other extensions like ublock.

@MurzNN
Copy link
Author

MurzNN commented Nov 1, 2017

Setting browser.tabs.remote.force-enable to false enables t2c again.

@markusb68 For me setting browser.tabs.remote.force-enable to false enable e10s on FF 56 successfully with t2c extension active, but after this - t2c stops adding t2c menu to right click on table. Did your FF adds menuitem normally with e10s enabled?

@markusb68
Copy link

try and set
browser.tabs.remote.autostart.2 to false
and
browser.tabs.remote.autostart to false

Then Menu is OK.
But Remember: You need to richt click on a table cell to get T2C menu item.

@markusb68
Copy link

try and set
browser.tabs.remote.autostart.2 to false
and
browser.tabs.remote.autostart to false

Then Menu is OK.
But Remember: You need to richt click on a table cell to get T2C menu item.

Also check about:support: Multiprocess Windows must be 0/1 (Disabled)

@MurzNN
Copy link
Author

MurzNN commented Nov 3, 2017

Those changes will disable e10s and we comes back to Firefox 40 :) I want to have Multiprocess with t2c together.

@markusb68
Copy link

Sorry, a.f.a.i.k. This is NOT Possible. Dafi needs to rewrite a lot of code for that.
What do you need Multiprocess for ?

@MurzNN
Copy link
Author

MurzNN commented Nov 3, 2017

Similar extension TableTools2 seems work normally with e10s force-enabled.

@MurzNN
Copy link
Author

MurzNN commented Nov 3, 2017

This is issue (feature request) for searching easy solution to make t2c compatible with e10s. I want multiprocess for increase Firefox performance and see crash restoring per-tab, not in the whole browser.

Very sad if this is not possible without total rewrite of code :(

@markusb68
Copy link

With FF 57 T2C won't work anyway. It's still marked "Legacy".

See.

@markusb68
Copy link

IMHO FF with Multiprocess is not remarkably faster.

@markusb68
Copy link

But anyhow, I NEED this T2C Function every day and would like to see Dafi spending the efffort, as long as there is no FF57 compatible replacement!

@MurzNN
Copy link
Author

MurzNN commented Nov 3, 2017

We can enable legacy extensions in Firefox 57 so if t2c can be easy patched for support e10s - this will be good improvement. In other extension sometimes we need to change only small lines in code for add support e10s. t2c don't need access to other tabs, so maybe there are exists some easy small fix for this.

@markusb68
Copy link

markusb68 commented Nov 3, 2017

Won't bet on that. on ghacks.net they write:

Legacy extension support will be dropped when the Beta version is updated to version 57 on October 10, 2017, and when the Release version of Firefox is updated to version 57 on November 14, 2017.

Nightly is special, as users of Firefox Nightly may bypass the restriction that blocks the usage of legacy extensions in the browser. The switch won't be part of Firefox Beta or Release.

@markusb68
Copy link

Check out Waterfox as an alternative

@dafi
Copy link
Member

dafi commented Nov 3, 2017

Hi,

I don't have time and energy to verify if T2C can be ported

@MurzNN
Copy link
Author

MurzNN commented Dec 19, 2017

I have found some replacements of table2clipboard extension for Firefox 57+ based on Webextensions API:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants