Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the automation to fix the build issue (hopefully.) #2

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

daVinci2793
Copy link
Owner

Made general script improvements:

  • Separation of Concerns
    • Pulled out the "fetch event details.
    • Pulled out "read descriptions"
    • Pulled out "generate readme"
  • Improved error handling
  • Path normalization for platform agnosticism
  • File open encoding to resolve the issues with reading in the data.
  • relative path construction to avoid the hard-coded slashes
    • This was to allow to dev on windows but run in github actions, which is linux based I think.
  • Included chardet to detect the encoding of the descriptions file.
  • Among other things, like clean up and optimizations.

@daVinci2793 daVinci2793 merged commit def5de7 into main Apr 21, 2024
1 check failed
@daVinci2793 daVinci2793 deleted the davincin/automation_fixes branch April 21, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant