-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix some peer dependency warnings #1417
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1417 +/- ##
===========================================
+ Coverage 86.05% 93.89% +7.84%
===========================================
Files 95 95
Lines 1606 1606
Branches 256 256
===========================================
+ Hits 1382 1508 +126
+ Misses 224 98 -126 ☔ View full report in Codecov by Sentry. |
Passing run #6167 ↗︎
Details:
Review all test suite changes for PR #1417 ↗︎ |
"@graphql-tools/graphql-file-loader": "7.3.10", | ||
"@graphql-tools/load": "7.5.9", | ||
"@material-ui/core": "4.12.4", | ||
"@material-ui/icons": "4.11.3", | ||
"@material-ui/lab": "4.0.0-alpha.61", | ||
"@matheusluizn/react-google-login": "^5.1.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the issues in react-google-login
is seems like most people are transitioning to the @react-oath/google package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mschile trying to switch to this one now - there are some differences in implementation between the two packages. Any objection with leaving this as-is in this PR since I don't have a ton of time to dedicate to this?
This comment was marked as resolved.
This comment was marked as resolved.
@MikeMcC399 good point. I figured that it was okay if this PR closed #1403 because I made specific issues for all of the other things that we need to do to get rid of warnings on install. What do you think? |
I'm hoping to update this PR to use the @react-oath/google package today, and then we can move forward |
You are right. So please do go ahead as you planned. |
Partially resolves #1403
@babel/core
,@babel/plugin-syntax-flow
,@babel/plugin-transform-react-jsx
,webpack
react-google-login
with@matheusluizn/react-google-login
to meet React 18 peer dependencies@xstate/react
to3.0.0
@percy/cypress
to3.2.1
percyHealthCheck
usage. Percy says that this isn't available or necessary past v2@cypress/webpack-dev-server