Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some peer dependency warnings #1417

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

astone123
Copy link
Contributor

@astone123 astone123 commented Oct 18, 2023

Partially resolves #1403

  • adds peer deps @babel/core, @babel/plugin-syntax-flow, @babel/plugin-transform-react-jsx, webpack
  • replaces react-google-login with @matheusluizn/react-google-login to meet React 18 peer dependencies
  • upgrades @xstate/react to 3.0.0
  • upgrades @percy/cypress to 3.2.1
  • removes @cypress/webpack-dev-server

@astone123 astone123 self-assigned this Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bfecadd) 86.05% compared to head (bb7e4cb) 93.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1417      +/-   ##
===========================================
+ Coverage    86.05%   93.89%   +7.84%     
===========================================
  Files           95       95              
  Lines         1606     1606              
  Branches       256      256              
===========================================
+ Hits          1382     1508     +126     
+ Misses         224       98     -126     

see 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 18, 2023

Passing run #6167 ↗︎

0 448 2 0 Flakiness 0

Details:

remove Percy healthcheck
Project: cypress-realworld-app Commit: bb7e4cbc05
Status: Passed Duration: 28:59 💡
Started: Oct 18, 2023 7:20 PM Ended: Oct 18, 2023 7:49 PM

Review all test suite changes for PR #1417 ↗︎

@astone123 astone123 requested review from mschile and mjhenkes October 18, 2023 19:56
"@graphql-tools/graphql-file-loader": "7.3.10",
"@graphql-tools/load": "7.5.9",
"@material-ui/core": "4.12.4",
"@material-ui/icons": "4.11.3",
"@material-ui/lab": "4.0.0-alpha.61",
"@matheusluizn/react-google-login": "^5.1.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the issues in react-google-login is seems like most people are transitioning to the @react-oath/google package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mschile trying to switch to this one now - there are some differences in implementation between the two packages. Any objection with leaving this as-is in this PR since I don't have a ton of time to dedicate to this?

@MikeMcC399

This comment was marked as resolved.

@astone123
Copy link
Contributor Author

@MikeMcC399 good point. I figured that it was okay if this PR closed #1403 because I made specific issues for all of the other things that we need to do to get rid of warnings on install. What do you think?

@astone123
Copy link
Contributor Author

I'm hoping to update this PR to use the @react-oath/google package today, and then we can move forward

@MikeMcC399
Copy link
Contributor

@astone123

good point. I figured that it was okay if this PR closed #1403 because I made specific issues for all of the other things that we need to do to get rid of warnings on install. What do you think?

You are right. So please do go ahead as you planned.

@astone123 astone123 requested a review from mschile October 23, 2023 22:32
@astone123 astone123 merged commit d3a57e7 into develop Oct 26, 2023
29 checks passed
@astone123 astone123 deleted the astone123/dependency-warnings branch October 26, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High number of installation warnings - vite
4 participants