Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official sources #15

Open
14 tasks
Tracked by #8
sneurlax opened this issue Mar 28, 2023 · 1 comment
Open
14 tasks
Tracked by #8

Use official sources #15

sneurlax opened this issue Mar 28, 2023 · 1 comment

Comments

@sneurlax
Copy link
Member

sneurlax commented Mar 28, 2023

Use EpicCash/epic-wallet instead of cypherstack/epic-wallet

Today's change in impls/src/adapters/epicbox.rs may be able to be circumvented by passing the epicbox domain to EpicboxBroker::post_slate as part of the address parameter (if the address isn't limited or validated to exclude it)

Using official sources would:

  • Remove a source of doubt in users' minds: they're using official code, they don't have to trust CypherStack
  • Remove a potential point of failure in a supply chain attack
  • Reduce the amount of times we have to publish a crate
  • Reduce the differences in comparisons between commits, branches, and forks because of stack_ prefixes

But there could be plenty of other issues with using official sources which lead to the choice to vendor and prefix epic-wallet.

Update 24-03-01:

The following crates were updated persuant to Epic Wallet's recent change from #40:

  • stack_epic_api
  • stack_epic_chain
  • stack_epic_core
  • stack_epic_keychain
  • stack_epic_p2p
  • stack_epic_pool
  • stack_epic_store
  • stack_epic_util
  • stack_epic_wallet_api
  • stack_epic_wallet_config
  • stack_epic_wallet_controller
  • stack_epic_wallet_impls
  • stack_epic_wallet_libwallet
  • and stack_epic_wallet_util

There may be more stack_epic_* packages, just doublecheck if we can point to the official epic_* crates, and if not, then we need to get these custom crates into source control

@sneurlax sneurlax mentioned this issue Mar 28, 2023
10 tasks
@sneurlax
Copy link
Member Author

sneurlax commented Mar 1, 2024

I see cypherstack/epic#1 and cypherstack/epic-wallet#1 ! Nice, that's the sauce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant