Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add SuccessThreshold #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Re-add SuccessThreshold #90

wants to merge 3 commits into from

Conversation

Robinlovelace
Copy link
Collaborator

No description provided.

@Robinlovelace Robinlovelace requested review from mvl22 and a team March 13, 2024 07:01
@Robinlovelace Robinlovelace linked an issue Mar 13, 2024 that may be closed by this pull request
Parameter emailOnCompletion should not e-mail a junk address by default #89
Open
@mvl22
Copy link
Member

mvl22 commented Dec 4, 2024

This looks fine, except that it mixes two separate things - the success threshold is not relevant to this ticket. Maybe just needs a rebase. Be good to get this one sorted.

@Robinlovelace
Copy link
Collaborator Author

Oh yes, forgot about this one..

@Robinlovelace Robinlovelace changed the title Remove email option, unused, fix #89 Re-add SuccessThreshold Dec 4, 2024
@Robinlovelace
Copy link
Collaborator Author

Rebased. So the email arg is removed and successThreshold (re?) added.

@Robinlovelace
Copy link
Collaborator Author

Cc @wangzhao0217 can you take a quick look and provide 👍

@Robinlovelace
Copy link
Collaborator Author

Look good to you @mvl22 after rebasing as per commit above?

@mvl22
Copy link
Member

mvl22 commented Dec 4, 2024

I can't actually work out what the resulting commit will be...

As far as I can see the successThreshold changes are still present. I don't think you intended that.

@Robinlovelace
Copy link
Collaborator Author

As far as I can see the successThreshold changes are still present. I don't think you intended that.

Yes I intended for that. We don't have access to that parameter at the moment. As you will see in the updated title of this PR its purpose now is to add that parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvl22 mvl22 Awaiting requested review from mvl22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameter emailOnCompletion should not e-mail a junk address by default
2 participants
@Robinlovelace @mvl22